Re: [PATCH]Implementation for IPv6 MIB:ipv6InterfaceTable

["David S. Miller" <davem@xxxxxxxxxx>]

On Tue, 14 Oct 2003 10:32:23 -0700
Shirley Ma <mashirle@xxxxxxxxxx> wrote:

> +#ifdef CONFIG_SYSCTL
> +#include <linux/sysctl.h>
> +#endif

Please don't add ifdefs around header includes like this if
you can avoid it.

> +void inet6_ifinfo_notify(int event, struct inet6_dev *idev);
 ...
> +extern int ndisc_ifinfo_sysctl_change(ctl_table *ctl, int write, struct file 
 ...
> +extern void inet6_ifinfo_notify(int event, struct inet6_dev *idev);
 ...

These belong in header files, not scattered around in *.c files.

Thanks.