Re: Tigon3 5701 PCI-X recv performance problem

["David S. Miller" <davem@xxxxxxxxxx>]

On Mon, 13 Oct 2003 14:53:54 -0500
John Partridge <johnip@xxxxxxx> wrote:

> Could we create a module argument like "do_5701_align" and just give it a -1
> default which does NOT do the copy but if we give the arg 1, 0, whatever it
> DOES to the copy to align the buffs ?

Absolutely not, we're not going to put super-hacky module parameters
into the driver just because you guys don't want to create and use the
CONFIG_UNALIGNED_EXPENSIVE config option needed to fix this properly.

> That way all the default comiles work and no CONFIG option for people
> who compile all defaults and don't want to re compile the kernel for
> this issue.
> 
> Is that acceptable ?

No it's not.

When you add this new config option, and set it on ia64, the only
thing that will need to be rebuilt is the tg3 driver, no other thing
in the entire kernel tree should trigger a dependency on this new
config option.

I don't understand why at all you guys are trying to avoid fixing this
the proper way, you will meet only resistence from me if you continue
doing that :)