netdev
[Top] [All Lists]

Re: [PATCH] Fix 64bit bugs in dscc44.c

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [PATCH] Fix 64bit bugs in dscc44.c
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 8 Oct 2003 09:01:32 -0700
Cc: ak@xxxxxx, ncorbic@xxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20031008155548.GB16937@wotan.suse.de>
References: <20031007175953.GA1802@averell> <20031008084205.5c81faac.davem@redhat.com> <20031008155548.GB16937@wotan.suse.de>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 8 Oct 2003 17:55:48 +0200
Andi Kleen <ak@xxxxxxx> wrote:

> I agree it would have been better to write:
> "ioremap and ioremap_nocache return pointers and that should 
> be stored in a pointer variable. However when you really want 
> to store them in a integer variable for unknown reasons always
> use unsigned long, not u32 or int"
> 
> However that was just too long, so I didn't write it.

Don't replace one error with a new warning, just add the cast
to the ioremap() call or something like that.

<Prev in Thread] Current Thread [Next in Thread>