Re: [PATCH] Fix 64bit bugs in dscc44.c

To:	Andi Kleen <ak@xxxxxx>
Subject:	Re: [PATCH] Fix 64bit bugs in dscc44.c
From:	"David S. Miller" <davem@xxxxxxxxxx>
Date:	Wed, 8 Oct 2003 08:42:05 -0700
Cc:	ncorbic@xxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to:	<20031007175953.GA1802@averell>
References:	<20031007175953.GA1802@averell>
Sender:	netdev-bounce@xxxxxxxxxxx

On Tue, 7 Oct 2003 19:59:53 +0200
Andi Kleen <ak@xxxxxx> wrote:

> ioremap_nocache returns unsigned long, not u32. This makes a difference
> on 64bit hosts.

Incorrect, like ioremap() it returns "void *".

Even your x86_64 implementation does this.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Fix 64bit bugs in dscc44.c, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc4.c, Francois Romieu Re: [PATCH] Fix 64bit bugs in dscc44.c, David S. Miller <= Re: [PATCH] Fix 64bit bugs in dscc44.c, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc44.c, David S. Miller Re: [PATCH] Fix 64bit bugs in dscc44.c, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc44.c II, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc44.c II, David S. Miller Re: [PATCH] Fix 64bit bugs in dscc44.c II, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc44.c II, David S. Miller Re: [PATCH] Fix 64bit bugs in dscc44.c II, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc44.c II, David S. Miller

Previous by Date:	Re: why does netfilter make upload very slow? (was: Re: e1000 -> 82540EM on linux 2.6.0-test[45] very slow in one direction), Harald Welte
Next by Date:	Re: [PATCH] dvb-net -- allocate network device structures, David S. Miller
Previous by Thread:	Re: [PATCH] Fix 64bit bugs in dscc4.c, Francois Romieu
Next by Thread:	Re: [PATCH] Fix 64bit bugs in dscc44.c, Andi Kleen
Indexes:	[Date] [Thread] [Top] [All Lists]