netdev
[Top] [All Lists]

Re: [PATCH] spinlock badness in last dongle changes.

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] spinlock badness in last dongle changes.
From: Jean Tourrilhes <jt@xxxxxxxxxxxxxxxxxx>
Date: Tue, 7 Oct 2003 19:03:31 -0700
Address: HP Labs, 1U-17, 1501 Page Mill road, Palo Alto, CA 94304, USA.
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
E-mail: jt@hpl.hp.com
In-reply-to: <20031006222631.1934f8e1.shemminger@osdl.org>
Organisation: HP Labs Palo Alto
References: <20031006222631.1934f8e1.shemminger@osdl.org>
Reply-to: jt@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Mon, Oct 06, 2003 at 10:26:31PM -0700, Stephen Hemminger wrote:
> On 2.6.0-test6 bk latest, rmmod of irda hangs on SMP...
> 
> A couple of locking problems happened when converted from using
> hashbin lock outside of irqueue.  First, the lock was never initialized;
> Second, the lock was being unlocked after the hashbin was free.
> 
> Since the hashbin of dongles should be empty (ie all dongle unregistered)
> don't really need locking there, so just warn if we find anything...

        I've recompiled my kernel with this patch and the trouble
modprobing the dongle driver went away.
        Thanks !

        Jean

<Prev in Thread] Current Thread [Next in Thread>