netdev
[Top] [All Lists]

Re: [2.6 PATCH] ipvs - remove some unused fields from the protocols

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [2.6 PATCH] ipvs - remove some unused fields from the protocols
From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Date: Tue, 07 Oct 2003 20:14:25 +1000
Cc: "David S. Miller" <davem@xxxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: Your message of "Tue, 07 Oct 2003 01:16:36 +0300." <Pine.LNX.4.44.0310070104470.6107-100000@u.domain.uli>
Sender: netdev-bounce@xxxxxxxxxxx
In message <Pine.LNX.4.44.0310070104470.6107-100000@xxxxxxxxxxxx> you write:
> 
>       Hello,
> 
>       The promised removal of some unused fields. For inclusion after 
> comments from Rusty. Rusty, it seems we can not convert the transmitters 
> to NF_STOLEN, ip_vs_null_xmit returns NF_ACCEPT.

Ah that's right.  I hit that as I was halfway through changing, and
reverted.  Sorry.

Leaving the comment there and adding one in ip_vs_null_xmit on why
breaking the rule in that case is OK is the right approach, I think.

Patch looks good!

Thanks,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

<Prev in Thread] Current Thread [Next in Thread>