netdev
[Top] [All Lists]

Re: [Bonding-announce] [PATCH SET][bonding] cleanup

To: Jay Vosburgh <fubar@xxxxxxxxxx>
Subject: Re: [Bonding-announce] [PATCH SET][bonding] cleanup
From: "Chad N. Tindel" <chad@xxxxxxxxxx>
Date: Thu, 25 Sep 2003 17:13:00 -0400
Cc: shmulik.hen@xxxxxxxxx, "Chad N. Tindel" <chad@xxxxxxxxxx>, bonding-devel@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, Jeff Garzik <jgarzik@xxxxxxxxx>, "Noam, Amir" <amir.noam@xxxxxxxxx>, "Mendelson, Tsippy" <tsippy.mendelson@xxxxxxxxx>, "Noam, Marom" <noam.marom@xxxxxxxxx>
In-reply-to: <200309251733.h8PHXWpV013559@death.ibm.com>
Mail-followup-to: Jay Vosburgh <fubar@xxxxxxxxxx>, shmulik.hen@xxxxxxxxx, "Chad N. Tindel" <chad@xxxxxxxxxx>, bonding-devel@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, Jeff Garzik <jgarzik@xxxxxxxxx>, "Noam, Amir" <amir.noam@xxxxxxxxx>, "Mendelson, Tsippy" <tsippy.mendelson@xxxxxxxxx>, "Noam, Marom" <noam.marom@xxxxxxxxx>
References: <shmulik.hen@intel.com> <200309252011.53960.shmulik.hen@intel.com> <200309251733.h8PHXWpV013559@death.ibm.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4i
> >>    I was going to add it on to the end of the clean up set, but
> >> if you want to do it, go ahead.  Nobody seems to have objected to
> >> removing the _OLD stuff, which I view as a good thing.
> 
>       My thinking here is that any ifenslave old enough (two years
> or more) to still be using the OLD ioctl values is unlikely to work
> with the current kernel driver, and if somebody did try it, it's
> better to have the call fail outright than perform weird and
> mysterious rituals in kernel memory.  I have trouble envisioning an
> scenario where a user would be using the latest 2.4.23 kernel, but an
> ifenslave from, what, 2.2.15? 2.4.5? or so.

I was specifically told by David Miller that we are not to break binary
compatibility within a 2.4 release.  Such things had to wait until 2.5 
or later.  We can not require a user to upgrade their ifenslave within a 2.4
series kernel just to keep using the same functionality they were using in 
2.4.1.  Obviously we can require them to upgrade in order to keep using
new functionality.  So the _OLD stuff needs to stay in the 2.4 kernel.  If
this was brought up in an earlier thread, then I just missed it.

Chad

<Prev in Thread] Current Thread [Next in Thread>