netdev
[Top] [All Lists]

Re: net/sctp/sm_make_chunk.c alignment problems on parisc64

To: Sridhar Samudrala <sri@xxxxxxxxxx>
Subject: Re: net/sctp/sm_make_chunk.c alignment problems on parisc64
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date: Thu, 25 Sep 2003 17:52:38 -0300
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx, lksctp-developers@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.44.0309221441070.5222-100000@localhost.localdomain>
Organization: Conectiva S.A.
References: <20030920155404.GA29040@conectiva.com.br> <Pine.LNX.4.44.0309221441070.5222-100000@localhost.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.4i
Em Mon, Sep 22, 2003 at 03:06:41PM -0700, Sridhar Samudrala escreveu:
> On Sat, 20 Sep 2003, Arnaldo Carvalho de Melo wrote:
> > The problem is right at:
> > 
> > tv_add(&asoc->cookie_life, &cookie->c.expiration);
> > 
> > Please send any patch you come up with, I'll be happy to test it.
> 
> The problem seems to be the static inline routine tv_add. When i converted it
> into a regular function or a macro, the problem went away. May be parisc64
> compiler has some issues with static inlines.
> 
> Arnaldo, Could you please try out this patch which converts tv_add() to a 
> macro
> TIMEVAL_ADD()

Yes, this makes the problem go away, if you have this tested please push it
DaveM's way, thanks a lot!

- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>