Re: [CHECKER] 32 Memory Leaks on Error Paths

netdev

Re: [CHECKER] 32 Memory Leaks on Error Paths

To:	Jörn Engel <joern@xxxxxxxxxxxxxxxxxxxx>
Subject:	Re: [CHECKER] 32 Memory Leaks on Error Paths
From:	"David S. Miller" <davem@xxxxxxxxxx>
Date:	Sat, 20 Sep 2003 00:58:11 -0700
Cc:	dychen@xxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, mc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to:	<20030916090748.GE27703@wohnheim.fh-wedel.de>
References:	<200309160435.h8G4ZkQM009953@elaine4.Stanford.EDU> <20030916090748.GE27703@wohnheim.fh-wedel.de>
Sender:	netdev-bounce@xxxxxxxxxxx

On Tue, 16 Sep 2003 11:07:48 +0200
Jörn Engel <joern@xxxxxxxxxxxxxxxxxxxx> wrote:

> Looks valid.  And since skb isn't really needed until after these
> returns, moving four lines down a bit fixes the problem.
> 
> Davem, is this correct?

Nope, now you're leaking the route instead of the SKB :-)

I'll put the correct fix in.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [CHECKER] 32 Memory Leaks on Error Paths, Jörn Engel Re: [CHECKER] 32 Memory Leaks on Error Paths, David S. Miller <=

Previous by Date:	Re: [PATCH] janitor: remove unneeded includes (wanrouter), David S. Miller
Next by Date:	Re: [PATCH] (4/6) ipvs -- use reader locks and refcounts correctly., David S. Miller
Previous by Thread:	Re: [CHECKER] 32 Memory Leaks on Error Paths, Jörn Engel
Next by Thread:	[PATCH][2.4][ATM] cleanup atm_dev_ioctl a bit (from mitch@sfgoth.com), chas williams
Indexes:	[Date] [Thread] [Top] [All Lists]