netdev
[Top] [All Lists]

[PATCH] get rid of dev_get in wanrouter

To: Nenad Corbic <ncorbic@xxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>
Subject: [PATCH] get rid of dev_get in wanrouter
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Mon, 15 Sep 2003 17:10:36 -0700
Cc: netdev@xxxxxxxxxxx
Organization: Open Source Development Lab
Sender: netdev-bounce@xxxxxxxxxxx
This call to dev_get() is racy and unnecessary because register_netdevice checks
if device already exists.

diff -Nru a/net/wanrouter/wanmain.c b/net/wanrouter/wanmain.c
--- a/net/wanrouter/wanmain.c   Mon Sep 15 17:06:43 2003
+++ b/net/wanrouter/wanmain.c   Mon Sep 15 17:06:43 2003
@@ -727,8 +727,6 @@
 
                if (dev->name == NULL) {
                        err = -EINVAL;
-               } else if (dev_get(dev->name)) {
-                       err = -EEXIST;  /* name already exists */
                } else {
 
                        #ifdef WANDEBUG

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] get rid of dev_get in wanrouter, Stephen Hemminger <=