netdev
[Top] [All Lists]

Re: ipt_physdev.c alignment problems on parisc64

To: Bart De Schuymer <bdschuym@xxxxxxxxxx>
Subject: Re: ipt_physdev.c alignment problems on parisc64
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 15 Sep 2003 15:59:03 -0700
Cc: laforge@xxxxxxxxxxxxx, acme@xxxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <200309132159.37834.bdschuym@pandora.be>
References: <200309022116.41697.bdschuym@pandora.be> <20030905153152.GA3623@obroa-skai.de.gnumonks.org> <20030908191400.5ef59ab6.davem@redhat.com> <200309132159.37834.bdschuym@pandora.be>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 13 Sep 2003 21:59:37 +0200
Bart De Schuymer <bdschuym@xxxxxxxxxx> wrote:

> -     char physindev[IFNAMSIZ];
> +     char physindev[IFNAMSIZ] __attribute__ ((aligned (__alignof__(unsigned 
> int))));

I have to reject the fix for this problem again.

You can't change the struct exported to userspace in any way
without breaking the tools.  I tried to explain this in the
first revision of your change.


<Prev in Thread] Current Thread [Next in Thread>