netdev
[Top] [All Lists]

Re: [PATCH] tiny af_packet.c cleanup

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: [PATCH] tiny af_packet.c cleanup
From: Mitchell Blank Jr <mitch@xxxxxxxxxx>
Date: Sun, 14 Sep 2003 04:26:28 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20030914125549.A7790@electric-eye.fr.zoreil.com>
References: <20030913055033.GB94744@gaz.sfgoth.com> <20030913093559.A23840@electric-eye.fr.zoreil.com> <20030913080252.GE94744@gaz.sfgoth.com> <20030913110353.B23840@electric-eye.fr.zoreil.com> <20030913201559.GI94744@gaz.sfgoth.com> <20030914125549.A7790@electric-eye.fr.zoreil.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
Francois Romieu wrote:
> See previously posted patch. Imho the non-trivial part isn't the locking
> itself but the fact that the first test of sk->sk_filter is done _without_
> lock.

OK, that was what I thought was going on.  I figured the short comment (along
with the likely()) would explain this adequately (i.e. "we're now re-checking
under lock so we get the authorative answer") but maybe it needs more
explaination.

-Mitch

<Prev in Thread] Current Thread [Next in Thread>