Re: synchronize_net()?

["David S. Miller" <davem@xxxxxxxxxx>]

On Fri, 12 Sep 2003 20:46:11 -0700
Mitchell Blank Jr <mitch@xxxxxxxxxx> wrote:

> /* Synchronize with packet receive processing. */
> void synchronize_net(void) 
> {
>         might_sleep();
>         synchronize_kernel();
> }
> 
> The "might_sleep()" isn't needed

As a matter of taste and ease of debugging it could be.

I think it's logical to place the might_sleep() calls as high
up in the call chain as is reasonable.  This is especially true
for important oft-used interfaces for a subsystem.

In this way, you don't risk so much having a hard to decode backtrace
that misses the true culprit sleep'able call.