Re: [PATCH] tiny af_packet.c cleanup

netdev

Re: [PATCH] tiny af_packet.c cleanup

To:	Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] tiny af_packet.c cleanup
From:	Mitchell Blank Jr <mitch@xxxxxxxxxx>
Date:	Sat, 13 Sep 2003 01:02:52 -0700
Cc:	netdev@xxxxxxxxxxx
In-reply-to:	<20030913093559.A23840@electric-eye.fr.zoreil.com>
References:	<20030913055033.GB94744@gaz.sfgoth.com> <20030913093559.A23840@electric-eye.fr.zoreil.com>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.4.1i

Francois Romieu wrote:
> 2 - I am not completely convinced that the "/* re-check under lock */" 
>     comment is really useful either: the lock statement is on the line before.

I thought that without the comment someone might think that the second
"if()" wasn't needed (since we had just checked the same value against
NULL a few lines up)

-Mitch

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] tiny af_packet.c cleanup, Mitchell Blank Jr Re: [PATCH] tiny af_packet.c cleanup, Francois Romieu Re: [PATCH] tiny af_packet.c cleanup, Mitchell Blank Jr <= Re: [PATCH] tiny af_packet.c cleanup, Francois Romieu Re: [PATCH] tiny af_packet.c cleanup, Mitchell Blank Jr Re: [PATCH] tiny af_packet.c cleanup, Francois Romieu Re: [PATCH] tiny af_packet.c cleanup, Mitchell Blank Jr Re: [PATCH] tiny af_packet.c cleanup, David S. Miller Re: [PATCH] tiny af_packet.c cleanup, Mitchell Blank Jr Re: [PATCH] tiny af_packet.c cleanup, David S. Miller

Previous by Date:	Re: [PATCH] tiny af_packet.c cleanup, Francois Romieu
Next by Date:	Re: IPv6 6to4 on site-local networks., David Woodhouse
Previous by Thread:	Re: [PATCH] tiny af_packet.c cleanup, Francois Romieu
Next by Thread:	Re: [PATCH] tiny af_packet.c cleanup, Francois Romieu
Indexes:	[Date] [Thread] [Top] [All Lists]