netdev
[Top] [All Lists]

Re: [PATCH] fix locking

To: Michael Rozhavsky <mike@xxxxxxxxxxxxx>
Subject: Re: [PATCH] fix locking
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 11 Sep 2003 16:49:03 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20030906002649.GA32369@server-mrozhavsky.dyndns.org>
References: <20030906002649.GA32369@server-mrozhavsky.dyndns.org>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 5 Sep 2003 17:26:49 -0700
Michael Rozhavsky <mike@xxxxxxxxxxxxx> wrote:

> I've found two problems with locking in networking code.

Not applied, in both cases a higher order lock guarentees
that nobody else can add elements to the list.

We only need to lock to make sure readers (who don't take
the higher level lock) see a consistent list state.

In the tcp_ipv4.c case, the higher level lock is the listening
socket lock.  In the sit.c case the higher level lock is the
RTNL semaphore.

<Prev in Thread] Current Thread [Next in Thread>