Re: [PATCH] fix locking

To:	Michael Rozhavsky <mike@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] fix locking
From:	"David S. Miller" <davem@xxxxxxxxxx>
Date:	Mon, 8 Sep 2003 19:21:15 -0700
Cc:	netdev@xxxxxxxxxxx
In-reply-to:	<20030906002649.GA32369@server-mrozhavsky.dyndns.org>
References:	<20030906002649.GA32369@server-mrozhavsky.dyndns.org>
Sender:	netdev-bounce@xxxxxxxxxxx

On Fri, 5 Sep 2003 17:26:49 -0700
Michael Rozhavsky <mike@xxxxxxxxxxxxx> wrote:

> I've found two problems with locking in networking code.

The tcp_ipv4.c part is not a bug.  We hold the socket lock on 'sk' and
therefore nobody else can add any entries to lopt->syn_table[]
entries.

We only need to hold the lock during the table update
because _readers_ of the hash table do not take the 'sk'
lock when do traverse the hash.

The sit.c change does look correct, and therefore I'll apply
it after some more review...

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] fix locking, Michael Rozhavsky Re: [PATCH] fix locking, David S. Miller <= Re: [PATCH] fix locking, David S. Miller

Previous by Date:	Re: ipt_physdev.c alignment problems on parisc64, David S. Miller
Next by Date:	[e1000 2.6 0/11] huge patch bomb, Feldman, Scott
Previous by Thread:	[PATCH] fix locking, Michael Rozhavsky
Next by Thread:	Re: [PATCH] fix locking, David S. Miller
Indexes:	[Date] [Thread] [Top] [All Lists]