netdev
[Top] [All Lists]

Re: [PATCH] sdla non-module build fix.

To: Linus Torvalds <torvalds@xxxxxxxx>
Subject: Re: [PATCH] sdla non-module build fix.
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Mon, 8 Sep 2003 10:33:24 -0700
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, <netdev@xxxxxxxxxxx>
In-reply-to: <Pine.LNX.4.44.0309081030310.15082-100000@home.osdl.org>
Organization: Open Source Development Lab
References: <20030908095708.107b98c4.shemminger@osdl.org> <Pine.LNX.4.44.0309081030310.15082-100000@home.osdl.org>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 8 Sep 2003 10:32:26 -0700 (PDT)
Linus Torvalds <torvalds@xxxxxxxx> wrote:

> 
> On Mon, 8 Sep 2003, Stephen Hemminger wrote:
> >
> > Last round of changes broke sdla build if not a module.
> 
> This patch can't be right. It may fix the compile, but it looks like 
> init/exit_sdla is never registered at all if it's built-in.
> 
> I suspect the whole #ifdef should go away. A driver that does things 
> differently depending on whether it is a module or not is generally a 
> _broken_ driver.
> 
>               Linus

The registration for non-modular takes place via drivers/net/Space.c 
calling sdla_init like it always did.

<Prev in Thread] Current Thread [Next in Thread>