netdev
[Top] [All Lists]

Re: [PATCH] (8/8) loopback device simplification

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] (8/8) loopback device simplification
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Thu, 4 Sep 2003 12:14:21 -0700
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20030903204105.0f01f131.davem@redhat.com>
Organization: Open Source Development Lab
References: <20030903164921.7d923008.shemminger@osdl.org> <3F568AC0.5090601@pobox.com> <20030903204105.0f01f131.davem@redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 3 Sep 2003 20:41:05 -0700
"David S. Miller" <davem@xxxxxxxxxx> wrote:

> On Wed, 03 Sep 2003 20:43:44 -0400
> Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
> 
> > Would be nice to move dev_base and dev_base_lock somewhere, maybe 
> > drivers/net/net_init.c (which really should be renamed libnet.c) or 
> > perhaps somewhere in net/*
> 
> Once all of the conversions are done, we can happily move
> this someone.  My personal preference would be net/core/dev.c,
> as I believe we can limit all of the modifications to there
> eventually and thus not have to export those two symbols to
> the entire kernel any more.
> 
> The fact that we export the list and it's locking makes it
> really hard to change things.

my current idea is to switch dev_base_lock over to RCU and
change dev_base to a list macro.

#define for_each_netdev(_d)   list_for_each_entry_rcu(_d, &netdev_base, 
dev_list)
...

<Prev in Thread] Current Thread [Next in Thread>