netdev
[Top] [All Lists]

[PATCH] comx - set owner on /proc entries

To: Pásztor Szilárd <silicon@xxxxxxxxxx>
Subject: [PATCH] comx - set owner on /proc entries
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Wed, 3 Sep 2003 11:40:00 -0700
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <Pine.GSO.4.00.10307221728360.10434-100000@kempelen.iit.bme.hu>
Organization: Open Source Development Lab
References: <013201c34f6f$0ae46410$2357e1c1@keszi> <Pine.GSO.4.00.10307221728360.10434-100000@kempelen.iit.bme.hu>
Sender: netdev-bounce@xxxxxxxxxxx
Set owner field on all the /proc entries created.

I know this is marked as OBSOLETE today, but Pásztor is working on it
and probably should include this

Builds, but no hardware to test...

diff -Nru a/drivers/net/wan/comx-hw-comx.c b/drivers/net/wan/comx-hw-comx.c
--- a/drivers/net/wan/comx-hw-comx.c    Wed Sep  3 11:36:22 2003
+++ b/drivers/net/wan/comx-hw-comx.c    Wed Sep  3 11:36:22 2003
@@ -1250,6 +1250,7 @@
            == NULL) {
            goto cleanup_HW_privdata;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &comxhw_read_proc;
        new_file->write_proc = &comxhw_write_proc;
@@ -1260,6 +1261,7 @@
            == NULL) {
            goto cleanup_filename_io;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &comxhw_read_proc;
        new_file->write_proc = &comxhw_write_proc;
@@ -1270,6 +1272,7 @@
            ch->procdir)) == NULL) {
            goto cleanup_filename_irq;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &comxhw_read_proc;
        new_file->write_proc = &comxhw_write_proc;
@@ -1281,6 +1284,7 @@
                   ch->procdir)) == NULL) {
                    goto cleanup_filename_channel;
                }
+               new_file->owner = THIS_MODULE;
                new_file->data = (void *)new_file;
                new_file->read_proc = &comxhw_read_proc;
                new_file->write_proc = &comxhw_write_proc;
@@ -1292,6 +1296,7 @@
            ch->procdir)) == NULL) {
                    goto cleanup_filename_clock;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &comxhw_read_proc;
        new_file->write_proc = &comxhw_write_proc;
@@ -1302,6 +1307,7 @@
            ch->procdir)) == NULL) {
                    goto cleanup_filename_memaddr;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &comxhw_read_proc;
        new_file->write_proc = NULL;
@@ -1311,6 +1317,7 @@
            ch->procdir)) == NULL) {
                    goto cleanup_filename_twin;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &comxhw_read_proc;
        new_file->write_proc = &comxhw_write_proc;
diff -Nru a/drivers/net/wan/comx-hw-locomx.c b/drivers/net/wan/comx-hw-locomx.c
--- a/drivers/net/wan/comx-hw-locomx.c  Wed Sep  3 11:36:22 2003
+++ b/drivers/net/wan/comx-hw-locomx.c  Wed Sep  3 11:36:22 2003
@@ -395,6 +395,7 @@
            ch->procdir)) == NULL) {
                goto cleanup_HW_privdata;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &locomx_read_proc;
        new_file->write_proc = &locomx_write_proc;
@@ -404,6 +405,7 @@
            ch->procdir)) == NULL)  {
                goto cleanup_filename_io;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &locomx_read_proc;
        new_file->write_proc = &locomx_write_proc;
@@ -415,6 +417,7 @@
            ch->procdir)) == NULL) {
                return -EIO;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &locomx_read_proc;
        new_file->write_proc = &locomx_write_proc;
diff -Nru a/drivers/net/wan/comx-hw-mixcom.c b/drivers/net/wan/comx-hw-mixcom.c
--- a/drivers/net/wan/comx-hw-mixcom.c  Wed Sep  3 11:36:22 2003
+++ b/drivers/net/wan/comx-hw-mixcom.c  Wed Sep  3 11:36:22 2003
@@ -841,6 +841,7 @@
            ch->procdir)) == NULL) {
                goto cleanup_HW_privdata;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &mixcom_read_proc;
        new_file->write_proc = &mixcom_write_proc;
@@ -850,6 +851,7 @@
            ch->procdir)) == NULL) {
                goto cleanup_filename_io;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &mixcom_read_proc;
        new_file->write_proc = &mixcom_write_proc;
@@ -860,6 +862,7 @@
            ch->procdir)) == NULL) {
                return -EIO;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &mixcom_read_proc;
        new_file->write_proc = &mixcom_write_proc;
@@ -870,6 +873,7 @@
            ch->procdir)) == NULL) {
                goto cleanup_filename_irq;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &mixcom_read_proc;
        new_file->write_proc = &mixcom_write_proc;
@@ -879,6 +883,7 @@
            ch->procdir)) == NULL) {
                goto cleanup_filename_channel;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &mixcom_read_proc;
        new_file->write_proc = &mixcom_write_proc;
diff -Nru a/drivers/net/wan/comx-hw-munich.c b/drivers/net/wan/comx-hw-munich.c
--- a/drivers/net/wan/comx-hw-munich.c  Wed Sep  3 11:36:22 2003
+++ b/drivers/net/wan/comx-hw-munich.c  Wed Sep  3 11:36:22 2003
@@ -2672,6 +2672,7 @@
     if ((new_file = create_proc_entry(FILENAME_BOARDNUM, S_IFREG | 0644,
                           ch->procdir)) == NULL)
        return init_escape(ch);
+    new_file->owner = THIS_MODULE;
     new_file->data = (void *)new_file;
     new_file->read_proc = &munich_read_proc;
     new_file->write_proc = &munich_write_proc;
@@ -2683,6 +2684,7 @@
        if ((new_file = create_proc_entry(FILENAME_TIMESLOTS, S_IFREG | 0644,
                               ch->procdir)) == NULL)
            return init_escape(ch);
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &munich_read_proc;
        new_file->write_proc = &munich_write_proc;
@@ -2692,6 +2694,7 @@
        if ((new_file = create_proc_entry(FILENAME_FRAMING, S_IFREG | 0644,
                               ch->procdir)) == NULL)
            return init_escape(ch);
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &munich_read_proc;
        new_file->write_proc = &munich_write_proc;
@@ -2701,6 +2704,7 @@
        if ((new_file = create_proc_entry(FILENAME_LINECODE, S_IFREG | 0644,
                               ch->procdir)) == NULL)
            return init_escape(ch);
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &munich_read_proc;
        new_file->write_proc = &munich_write_proc;
@@ -2710,6 +2714,7 @@
        if ((new_file = create_proc_entry(FILENAME_CLOCK_SOURCE, S_IFREG | 0644,
                               ch->procdir)) == NULL)
            return init_escape(ch);
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &munich_read_proc;
        new_file->write_proc = &munich_write_proc;
@@ -2719,6 +2724,7 @@
        if ((new_file = create_proc_entry(FILENAME_LOOPBACK, S_IFREG | 0644,
                               ch->procdir)) == NULL)
            return init_escape(ch);
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &munich_read_proc;
        new_file->write_proc = &munich_write_proc;
@@ -2729,6 +2735,7 @@
     /* DEL: ez itt csak fejlesztesi celokra!! */
     if ((new_file = create_proc_entry(FILENAME_REG, S_IFREG | 0200, 
ch->procdir)) == NULL)
        return init_escape(ch);
+    new_file->owner = THIS_MODULE;
     new_file->data = (void *)new_file;
     new_file->read_proc = &munich_read_proc;
     new_file->write_proc = &munich_write_proc;
@@ -2739,6 +2746,7 @@
     if ((new_file = create_proc_entry(FILENAME_LBIREG, S_IFREG | 0200,
                           ch->procdir)) == NULL)
        return init_escape(ch);
+    new_file->owner = THIS_MODULE;
     new_file->data = (void *)new_file;
     new_file->read_proc = &munich_read_proc;
     new_file->write_proc = &munich_write_proc;
diff -Nru a/drivers/net/wan/comx-proto-fr.c b/drivers/net/wan/comx-proto-fr.c
--- a/drivers/net/wan/comx-proto-fr.c   Wed Sep  3 11:36:22 2003
+++ b/drivers/net/wan/comx-proto-fr.c   Wed Sep  3 11:36:22 2003
@@ -810,6 +810,7 @@
            ch->procdir)) == NULL) {
                goto cleanup_LINE_privdata;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &fr_read_proc;
        new_file->write_proc = &fr_write_proc;
@@ -820,6 +821,7 @@
            ch->procdir)) == NULL) {
                goto cleanup_filename_dlci;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &fr_read_proc;
        new_file->write_proc = &fr_write_proc;
@@ -870,6 +872,7 @@
                goto cleanup_LINE_privdata;
        }
        
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &fr_read_proc;
        new_file->write_proc = &fr_write_proc;
@@ -880,6 +883,7 @@
            ch->procdir)) == NULL) {
                goto cleanup_filename_dlci;
        }
+       new_file->owner = THIS_MODULE;
        new_file->data = (void *)new_file;
        new_file->read_proc = &fr_read_proc;
        new_file->write_proc = &fr_write_proc;
diff -Nru a/drivers/net/wan/comx-proto-lapb.c 
b/drivers/net/wan/comx-proto-lapb.c
--- a/drivers/net/wan/comx-proto-lapb.c Wed Sep  3 11:36:22 2003
+++ b/drivers/net/wan/comx-proto-lapb.c Wed Sep  3 11:36:22 2003
@@ -499,6 +499,7 @@
        struct proc_dir_entry *new_file;
 
        if ((new_file = create_proc_entry(name, S_IFREG | mode, dir)) != NULL) {
+               new_file->owner = THIS_MODULE;
                new_file->data = (void *)new_file;
                new_file->read_proc = &comxlapb_read_proc;
                new_file->write_proc = &comxlapb_write_proc;
diff -Nru a/drivers/net/wan/comx.c b/drivers/net/wan/comx.c
--- a/drivers/net/wan/comx.c    Wed Sep  3 11:36:22 2003
+++ b/drivers/net/wan/comx.c    Wed Sep  3 11:36:22 2003
@@ -563,7 +563,6 @@
        return min_t(int, count, len - off);
 }
 
-
 static int comx_root_read_proc(char *page, char **start, off_t off, int count, 
        int *eof, void *data)
 {
@@ -788,6 +787,7 @@
                goto cleanup_dev;
        }
 
+       new_dir->owner = THIS_MODULE;
        new_dir->nlink = 2;
        new_dir->data = NULL; // ide jon majd a struct dev
 
@@ -811,6 +811,7 @@
            S_IFREG | 0644, new_dir)) == NULL) {
                goto cleanup_filename_lineupdelay;
        }
+       debug_file->owner = THIS_MODULE;
        debug_file->data = (void *)debug_file; 
        debug_file->read_proc = NULL; // see below
        debug_file->write_proc = &comx_write_proc;
@@ -972,6 +973,7 @@
        struct proc_dir_entry *new_file;
 
        if ((new_file = create_proc_entry(name, S_IFREG | mode, dir)) != NULL) {
+               new_file->owner = THIS_MODULE;
                new_file->data = (void *)new_file;
                new_file->read_proc = &comx_read_proc;
                new_file->write_proc = &comx_write_proc;
@@ -1077,6 +1079,7 @@
                S_IFDIR | S_IWUSR | S_IRUGO | S_IXUGO, &proc_root);
        if (!comx_root_dir)
                return -ENOMEM;
+       comx_root_dir->owner = THIS_MODULE;
        comx_root_dir->proc_iops = &comx_root_inode_ops;
 
        if ((new_file = create_proc_entry(FILENAME_HARDWARELIST, 
@@ -1084,6 +1087,7 @@
                return -ENOMEM;
        }
        
+       new_file->owner = THIS_MODULE;
        new_file->data = new_file;
        new_file->read_proc = &comx_root_read_proc;
        new_file->write_proc = NULL;
@@ -1094,6 +1098,7 @@
                return -ENOMEM;
        }
        
+       new_file->owner = THIS_MODULE;
        new_file->data = new_file;
        new_file->read_proc = &comx_root_read_proc;
        new_file->write_proc = NULL;


<Prev in Thread] Current Thread [Next in Thread>