netdev
[Top] [All Lists]

Re: ethtool_features?

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: ethtool_features?
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 27 Aug 2003 23:52:58 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <3F4D2F2B.2090401@pobox.com>
References: <3F4D2F2B.2090401@pobox.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 27 Aug 2003 18:22:35 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> Hum.  Instead of adding all these _get_foo ops to test dev->features 
> bits, would anyone mind if I created a single _get_features() ethtool 
> sub-ioctl?

I'm personally OK with this _iff_ you add values local
to ethtool for the various feature bits.  Ie. don't
export the NETIF_F_* values to userspace.

<Prev in Thread] Current Thread [Next in Thread>