| To: | Francois Romieu <romieu@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] (4/4) convert irlan to seq_file interface |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Mon, 18 Aug 2003 15:05:14 -0700 |
| Cc: | Jean Tourrilhes <jt@xxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, irda-users@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20030818232554.A7779@electric-eye.fr.zoreil.com> |
| Organization: | Open Source Development Lab |
| References: | <20030818122702.67e9162d.shemminger@osdl.org> <20030818232554.A7779@electric-eye.fr.zoreil.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
I did a one step at a time conversion.
> void irlan_print_filter(struct seq_file *seq, int filter_type)
> {
> static struct {
> int mask;
> char *str;
> } filter_mask2str[] = {
> { IRLAN_DIRECTED, "DIRECTED" },
> { IRLAN_FUNCTIONAL, "FUNCTIONAL" },
> { IRLAN_GROUP, "GROUP" },
> { IRLAN_MAC_FRAME, "MAC_FRAME" },
> { IRLAN_MULTICAST, "MULTICAST" },
> { IRLAN_BROADCAST, "BROADCAST" },
> { IRLAN_IPX_SOCKET, "IPX_SOCKET" },
> { 0, NULL }
> }, *p;
>
> for (p = filter_mask2str; p->str; p++) {
> if (filter_type & p->mask)
> seq_printf(seq, "%s ", p->str);
> }
> seq_putc(seq, '\n');
> }
If you are going to do that (and it looks good). Make the str a const
and use C99 initializers?
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [2.4 PATCH] bugfix: ARP respond on all devices, Bill Davidsen |
|---|---|
| Next by Date: | Re: [PATCH] (4/4) convert irlan to seq_file interface, Francois Romieu |
| Previous by Thread: | Re: [PATCH] (4/4) convert irlan to seq_file interface, Francois Romieu |
| Next by Thread: | Re: [PATCH] (4/4) convert irlan to seq_file interface, Francois Romieu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |