| To: | Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] (10/11) netrom - convert /proc interface to seq_file |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Thu, 14 Aug 2003 11:30:25 -0700 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxx>, Jeroen Vreeken <pe1rxq@xxxxxxxxx>, linux-hams@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20030814172539.GD1785@conectiva.com.br> |
| Organization: | Open Source Development Lab |
| References: | <20030813154635.376df59b.shemminger@osdl.org> <20030814172539.GD1785@conectiva.com.br> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Thu, 14 Aug 2003 14:25:39 -0300 Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx> wrote: > Em Wed, Aug 13, 2003 at 03:46:35PM -0700, Stephen Hemminger escreveu: > > Convert netrom /proc interface to seq_file. > > > > diff -Nru a/include/net/netrom.h b/include/net/netrom.h > > --- a/include/net/netrom.h Wed Aug 13 13:54:19 2003 > > +++ b/include/net/netrom.h Wed Aug 13 13:54:19 2003 > > + seq_printf(seq, "%-9s ", ax2asc(&nr->user_addr)); > > + seq_printf(seq, "%-9s ", ax2asc(&nr->dest_addr)); > > + seq_printf(seq, > > +"%-9s %-3s %02X/%02X %02X/%02X %2d %3d %3d %3d %3lu/%03lu %2lu/%02lu > > %3lu/%03lu %3lu/%03lu %2d/%02d %3d %5d %5d %ld\n", > > <nitpick> why not just one seq_printf call? </nitpick> ax2asc() returns a pointer to static buffer. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] IPsec: add support for Twofish and Serpent, Pekka Pietikainen |
|---|---|
| Next by Date: | Fix to have sysfs track rename of network devices, Mark Huth |
| Previous by Thread: | Re: [PATCH] (10/11) netrom - convert /proc interface to seq_file, Arnaldo Carvalho de Melo |
| Next by Thread: | Re: [PATCH] (10/11) netrom - convert /proc interface to seq_file, Arnaldo Carvalho de Melo |
| Indexes: | [Date] [Thread] [Top] [All Lists] |