| To: | Jeroen Vreeken <pe1rxq@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] ax25 & netrom fixes for 2.6 |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Wed, 13 Aug 2003 03:10:38 -0700 |
| Cc: | shemminger@xxxxxxxx, pe1rxq@xxxxxxxxx, linux-hams@xxxxxxxxxxxxxxx, ralf@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20030812230951.E28977@jeroen.pe1rxq.ampr.org> |
| References: | <20030812194653.A28977@jeroen.pe1rxq.ampr.org> <20030812135655.7334887b.shemminger@osdl.org> <20030812230951.E28977@jeroen.pe1rxq.ampr.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Tue, 12 Aug 2003 23:09:51 +0200 Jeroen Vreeken <pe1rxq@xxxxxxxxx> wrote: > Since at the moment the only zero-copy path I can imagine is from packets > over a bpq ethernet device wouldn't it be the easiest to just check at > ax25_rcv() for non-linear packets and call skb_linearize() for them? skb_linearize() is a deprecated interface, no new pieces of code should use it. If you want to mark the protocol as a new one you must do the non-linear handling properly just like every other protocol. Please, if you're going to be working in this area, fix this up properly and don't paper around the problems Stephen is showing to you. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC] High Performance Packet Classifiction for tc framework, Jamie Lokier |
|---|---|
| Next by Date: | Re: [PATCH] Convert ax25 to seq_file, David S. Miller |
| Previous by Thread: | Re: [RFT][PATCH] ax25 using seq_file, Jeroen Vreeken |
| Next by Thread: | [PATCH] make lapbether work on 2.6.0-test3, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |