| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: RFR: new SiS gige driver |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Fri, 8 Aug 2003 23:39:40 -0700 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20030808173932.GA4077@gtf.org> |
| References: | <20030808173932.GA4077@gtf.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 8 Aug 2003 13:39:33 -0400 Jeff Garzik <jgarzik@xxxxxxxxx> wrote: > This driver is actually a lot more clean than many that crop up. So far > most of my nits are minor: egrep virt_to_bus sis190.c :-( I think this is more important to fix than any of the other things which have been listed. I really believe we're at the point where putting PCI device drivers into the tree still using virt_to_bus() and friends should simply not be allowed... |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC] High Performance Packet Classifiction for tc framework, David S. Miller |
|---|---|
| Next by Date: | [PATCH] IPVS: linkage error without CONFIG_IP_VS_PROTO_TCP, YOSHIFUJI Hideaki / 吉藤英明 |
| Previous by Thread: | Re: RFR: new SiS gige driver, Stephen Hemminger |
| Next by Thread: | Re: RFR: new SiS gige driver, Andi Kleen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |