Re: RFR: new SiS gige driver

[Stephen Hemminger <shemminger@xxxxxxxx>]

Comments:
        - Run through lindent, indenting is non-standard.

        - struct board_info defined but only used in one debug message
          and it is just a string.

        - C99 initializers?

        - if code is commented out and outdated remove it (see init_board)

        - poisoning memory is useless and done already by allocator
          (see SIS190_remove_one)

        - assert checks for null pointers are overkill

        - ethtool?

Overall, suffers a little from the "having more debug code makes my
driver more reliable" fallacy.