netdev
[Top] [All Lists]

Re: (usagi-core 14846) [PATCH] IPv6: No fragmentation of packets with le

To: vnuorval@xxxxxxxxxx
Subject: Re: (usagi-core 14846) [PATCH] IPv6: No fragmentation of packets with length <= mtu
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Wed, 06 Aug 2003 19:28:24 +0900 (JST)
Cc: netdev@xxxxxxxxxxx, usagi-core@xxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.44.0308061039550.1401-200000@rhea.tcs.hut.fi>
Organization: USAGI Project
References: <Pine.LNX.4.44.0308061039550.1401-200000@rhea.tcs.hut.fi>
Sender: netdev-bounce@xxxxxxxxxxx
In article <Pine.LNX.4.44.0308061039550.1401-200000@xxxxxxxxxxxxxxx> (at Wed, 6 
Aug 2003 13:00:41 +0300 (EEST)), Ville Nuorvala <vnuorval@xxxxxxxxxx> says:

> I noticed ip6_append_data() always reserves space for the fragment header
> at the cost of the payload data. This leads to the unnecessary
> fragmentation of packets with lengths close (or equal) to the link-mtu.
> This can for example be seen with ping6 -s 1448 (on an ethernet link).
> 
> My attached patch _seems_ to fix the problem without breaking anything
> else, but can you still verify this?

Well, your patch breaks something; the idea of append_data.
User may "push" multiple times to generate a packet.

I'm chasing this bug.
Since this bug is not grave, we do not need to fix this ASAP;
We need to fix a grave issue with UDPv6 with MSG_MORE flag 
before this.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

<Prev in Thread] Current Thread [Next in Thread>