netdev
[Top] [All Lists]

[PATCH] fix airo memory leak

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: [PATCH] fix airo memory leak
From: Daniel Ritz <daniel.ritz@xxxxxx>
Date: Sat, 2 Aug 2003 17:43:12 +0200
Cc: linux-net <linux-net@xxxxxxxxxxxxxxx>, "linux-netdev" <netdev@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5.2
fixes a memory leak: memory for the airo_devices list is allocated but
never freed.

against 2.6.0-test2-bk, but should apply to 2.4 as well...



--- 1.54/drivers/net/wireless/airo.c    Sun Jul 20 05:17:02 2003
+++ edited/drivers/net/wireless/airo.c  Sat Aug  2 17:33:24 2003
@@ -4038,12 +4038,23 @@
        return 0;
 }
 
-static void del_airo_dev( struct net_device *dev ) {
-       struct net_device_list **p = &airo_devices;
-       while( *p && ( (*p)->dev != dev ) )
-               p = &(*p)->next;
-       if ( *p && (*p)->dev == dev )
-               *p = (*p)->next;
+static void del_airo_dev(struct net_device *dev)
+{
+       struct net_device_list *this = airo_devices, *prev = NULL;
+
+       while (this) {
+               if (this->dev == dev) {
+                       if (prev)
+                               prev->next = this->next;
+                       else
+                               airo_devices = this->next;
+                       kfree(this);
+                       break;  
+               }
+
+               prev = this;
+               this = this->next;
+       }
 }
 
 #ifdef CONFIG_PCI


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] fix airo memory leak, Daniel Ritz <=