netdev
[Top] [All Lists]

Re: comx drivers in 2.6

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: comx drivers in 2.6
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Fri, 18 Jul 2003 12:36:25 -0700
Cc: Gergely Madarasz <gorgo@xxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <3F173458.6060405@pobox.com>
Organization: Open Source Development Lab
References: <20030717163337.78d123c0.shemminger@osdl.org> <3F173458.6060405@pobox.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 17 Jul 2003 19:42:16 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> Stephen Hemminger wrote:
> > It looks like the comx drivers never got updated for 2.5/2.6.  Some
> > obvious issues are:
> >     - lots of use of /proc files without setting the owner field.
> >     - still using cli/sti
> >     - no SMP locking on the linked list (which could be changed to list 
> > macros)
> >       of hardware and protocols.
> > 
> > Just bumped into this while trying to inspect for all the last possible
> > broken usage of net_device structure.  It is too far behind to address
> > those issues.
> 
> 
> Submit a patch to mark these CONFIG_OBSOLETE.  AFAIK nobody has cared 
> for most of them since 2.2...  (munich is an exception)
> 

diff -Nru a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig
--- a/drivers/net/wan/Kconfig   Fri Jul 18 11:55:47 2003
+++ b/drivers/net/wan/Kconfig   Fri Jul 18 11:55:47 2003
@@ -60,9 +60,10 @@
 #
 # COMX drivers
 #
+# Not updated to 2.6.
 config COMX
        tristate "MultiGate (COMX) synchronous serial boards support"
-       depends on WAN && (ISA || PCI)
+       depends on WAN && (ISA || PCI) && OBSOLETE
        ---help---
          Say Y if you want to use any board from the MultiGate (COMX) family.
          These boards are synchronous serial adapters for the PC,


<Prev in Thread] Current Thread [Next in Thread>