netdev
[Top] [All Lists]

Re: [PATCH] [1/2] kernel error reporting (revised)

To: akpm@xxxxxxxx (Andrew Morton)
Subject: Re: [PATCH] [1/2] kernel error reporting (revised)
From: kuznet@xxxxxxxxxxxxx
Date: Wed, 16 Jul 2003 03:10:47 +0400 (MSD)
Cc: jkenisto@xxxxxxxxxx, jmorris@xxxxxxxxxxxxxxxx, davem@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx, alan@xxxxxxxxxxxxxxxxxxx, rddunlap@xxxxxxxx, kuznet@xxxxxxxxxxxxx
In-reply-to: <20030715125121.315920a2.akpm@osdl.org> from "Andrew Morton" at éÀÌ 15, 2003 12:51:21
Sender: netdev-bounce@xxxxxxxxxxx
Hello!

> netlink_broadcast() does read_lock(&nl_table_lock).  But nl_table_lock is
> not an irq-safe lock.

Just as reminder, there are _no_ irq safe locks in net/*. A few of
local_irq_disable()s are segregated in interface to device drivers.


> Possibly netlink_broadcast() can be made callable from hardirq context, but
> it looks to be non trivial.

Trivial or non-trivial, before all this is highly not desired.
net/* is better to remain in the form free of knowledge of hardirqs.

Alexey

<Prev in Thread] Current Thread [Next in Thread>