| To: | James Morris <jmorris@xxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Sat, 12 Jul 2003 22:34:49 -0700 |
| Cc: | jkenisto@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, akpm@xxxxxxxx, jgarzik@xxxxxxxxx, alan@xxxxxxxxxxxxxxxxxxx, rddunlap@xxxxxxxx, kuznet@xxxxxxxxxxxxx |
| In-reply-to: | <Mutt.LNX.4.44.0307131052420.2146-100000@excalibur.intercode.com.au> |
| References: | <20030711224142.557b5b5e.davem@redhat.com> <Mutt.LNX.4.44.0307131052420.2146-100000@excalibur.intercode.com.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sun, 13 Jul 2003 11:17:35 +1000 (EST) James Morris <jmorris@xxxxxxxxxxxxxxxx> wrote: > On Fri, 11 Jul 2003, David S. Miller wrote: > > > Oops, turns out this doesn't work. data_ready is never NULL, look at > > how netlink_kernel_create() works. > > It's ok: sk->data_ready is never null, but nlk_sk(sk)->data_ready will be > null unless an input function is provided there. > > > Also, the broadcast case probably needs to be handled > > too? > > Netlink sockets created by netlink_kernel_create() do not subscribe to any > groups and are not broadcast to. Oops, you're right on both counts, I brainfarted here. I'll apply your original patch, thanks. |
| Previous by Date: | Re: networking bugs and bugme.osdl.org, Jan Rychter |
|---|---|
| Next by Date: | Re: disablenetwork() syscall?, Pekka Savola |
| Previous by Thread: | Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting, James Morris |
| Next by Thread: | [PATCH] [1/2] kernel error reporting (revised), Jim Keniston |
| Indexes: | [Date] [Thread] [Top] [All Lists] |