Re: [PATCH] Move eth_mac_addr and eth_change_mtu

[Matthew Wilcox <willy@xxxxxxxxxx>]

On Fri, Jul 11, 2003 at 04:57:21PM -0400, Jeff Garzik wrote:
> Well, I don't see/understand this next-stage, so elaboration would be 
> nice.  As-is, I do not support merging this patch.

It's the next stage you're calling for -- move these functions:

        dev->change_mtu         = eth_change_mtu;
        dev->hard_header        = eth_header;
        dev->rebuild_header     = eth_rebuild_header;
        dev->set_mac_address    = eth_mac_addr;
        dev->hard_header_cache  = eth_header_cache;
        dev->header_cache_update= eth_header_cache_update;
        dev->hard_header_parse  = eth_header_parse;

into netdev_ops.  Which means each driver will need to see them.

I thought I could justify moving these functions already on the grounds
that if you were looking for the definition of eth_change_mtu(),
net_init.c would be a much less likely place to look than
net/ethernet/eth.c

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk