On Wed, Jul 09, 2003 at 10:11:04AM -0700, Ben Greear wrote:
> Considering any number of things may change in the future, what do
> you think of adding a global 'nettool-version' method. That could
> allow user-space code to take appropriate action if something ever
> changes in a non-compatible way....
This patch makes only user-invisible changes. I'm trying to establish a
base for further cleanups (eg, acme wants to look at unifying the wireless
ops and the existing net_device function pointers into netdev_ops).
I don't really have a position on adding a nettool-version ioctl or
whatever, but I'm not sure it would make sense to have that as a netdev
method.
> Also, for the strings (labels) passed back to user space, is there any
> documentation for suggested values for these strings? Even though we
> can't be completely type-safe, if there were suggested values in
> a comment in the code, it could help a great deal for any code trying to
> parse them for multiple different drivers/nics.
I didn't see any documentation; I just read the code. The only drivers
I noticed supporting the GSTRINGS subcommand are 8139cp, 8139too, e100
and e1000.
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
|