netdev
[Top] [All Lists]

Re: [PATCH, untested] Support for PPPOE on SMP

To: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH, untested] Support for PPPOE on SMP
From: Jamal Hadi <hadi@xxxxxxxxxxxxxxxx>
Date: Wed, 25 Jun 2003 07:19:55 -0400 (EDT)
Cc: davem@xxxxxxxxxx, paulus@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030625072602.529AF2C0B9@lists.samba.org>
References: <20030625072602.529AF2C0B9@lists.samba.org>
Sender: netdev-bounce@xxxxxxxxxxx

On Wed, 25 Jun 2003, Rusty Russell wrote:

> Paul Mackerras says PPPoE relies on receiving packets in wire order,
> and he has bug reports caused by packet reordering.
>

I dont know of any ordering dependencies with pppoe. Is this a bug
in the ppp code?

> This is icky.

Yes it is ;->
The effects of your patch could be achieved in two ways:
a) tie the pppoe related ethernet card to a processor.
b) use a NAPI caopable ethernet card.

Now, if there is a real need to have a serialization queue (i dont see
one) you really dont need to tie to a processor. Just have a single queue
shared by all processors; every one grabs a lock to it.

cheers,
jamal

<Prev in Thread] Current Thread [Next in Thread>