netdev
[Top] [All Lists]

[PATCH] missing owner field entry on pppoe /proc

To: "David S. Miller" <davem@xxxxxxxxxx>, Michal Ostrowski <mostrows@xxxxxxxxxxxxxxxxx>
Subject: [PATCH] missing owner field entry on pppoe /proc
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Thu, 19 Jun 2003 12:20:24 -0700
Cc: netdev@xxxxxxxxxxx
Organization: Open Source Development Lab
Sender: netdev-bounce@xxxxxxxxxxx
The /proc file operations for PPPOE is missing an owner entry.   This means that
if someone has /proc file open, it is still possible to unload the module.

Patch against 2.5.72 

diff -Nru a/drivers/net/pppoe.c b/drivers/net/pppoe.c
--- a/drivers/net/pppoe.c       Thu Jun 19 12:17:27 2003
+++ b/drivers/net/pppoe.c       Thu Jun 19 12:17:28 2003
@@ -1061,6 +1061,7 @@
 }
 
 static struct file_operations pppoe_seq_fops = {
+       .owner          = THIS_MODULE,
        .open           = pppoe_seq_open,
        .read           = seq_read,
        .llseek         = seq_lseek,

<Prev in Thread] Current Thread [Next in Thread>