From: Andi Kleen <ak@xxxxxxx>
Date: Sat, 14 Jun 2003 20:32:32 +0200
On Sat, Jun 14, 2003 at 04:26:36AM -0700, David S. Miller wrote:
> From: Andi Kleen <ak@xxxxxxx>
> Date: Sat, 14 Jun 2003 12:18:51 +0200
>
> Allocating it at first lookup would be racy (would need a nasty
> spinlock at least). It may be possible at first policy setup, but
> it's not guaranteed you can still get two 32K continuous areas. You
> could fall back to vmalloc I guess.
>
> Andi, you're getting rediculious. Add a xfrm_whatever_init() call
> and allocate the table there.
Did you actually read what I wrote? Allocating on init is useless
from the bloat perspective because it's 100% equivalent to an BSS
allocation.
If dynamic, you could allocate a "tiny" hash table or whatever
on bootup and grow it as usage increases, much like we grow the
FIB hashes dynamically.
|