Re: [PATCH 2.5.70+] tun using alloc_netdev

[Stephen Hemminger <shemminger@xxxxxxxx>]

On Wed, 11 Jun 2003 15:43:18 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> On Wed, Jun 11, 2003 at 12:21:44PM -0700, Max Krasnyansky wrote:
> > At 11:58 AM 6/9/2003, Stephen Hemminger wrote:
> > 
> > 
> > >-               if ((err = dev_alloc_name(&tun->dev, name)) < 0)
> > >-                       goto failed;
> > >-               if ((err = register_netdevice(&tun->dev)))
> > >+               dev = alloc_netdev(sizeof(struct tun_struct), name,
> > >+                                  tun_setup);
> > >+               if (!dev)
> > >+                       return -ENOMEM;
> > >+
> > >+               tun = dev->priv;
> > >+               tun->flags = flags;
> > >+
> > >+               if ((err = register_netdevice(tun->dev))) {
> > >+                       kfree(dev);
> > >                        goto failed;
> > >+               }
> > 
> > 
> > This is wrong. register_netdevice() does not expand name (ie %d stuff).
> > So dev_alloc_name() is still needed. i.e.
> 
> Correct.
> 
> But, register_netdev() is preferred precisely for this reason.
> 

Not possible in this case because device is created off socket ioctl so it is
called with rtnl_lock