Re: [BUG] drivers/net/ioc3_eth.c in 2.5

[Stephen Hemminger <shemminger@xxxxxxxx>]

On Mon, 9 Jun 2003 13:12:24 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> On Mon, Jun 09, 2003 at 10:10:18AM -0700, Stephen Hemminger wrote:
> > Looks like the right fix is:
> > --- ioc3-eth.c.orig 2003-06-09 10:05:45.000000000 -0700
> > +++ ioc3-eth.c      2003-06-09 10:04:45.000000000 -0700
> > @@ -1614,6 +1614,7 @@ static void __devexit ioc3_remove_one (s
> >     struct ioc3 *ioc3 = ip->regs;
> >  
> >     iounmap(ioc3);
> > +   unregister_netdev(dev);
> >     pci_release_regions(pdev);
> >     kfree(dev);
> >  }
> 
> You want to unregister before iounmap.
> 
>       Jeff
> 
> 
Okay:
--- ioc3-eth.c.orig     2003-06-09 10:05:45.000000000 -0700
+++ ioc3-eth.c  2003-06-09 11:08:01.000000000 -0700
@@ -1613,6 +1613,7 @@ static void __devexit ioc3_remove_one (s
        struct ioc3_private *ip = dev->priv;
        struct ioc3 *ioc3 = ip->regs;
 
+       unregister_netdev(dev);
        iounmap(ioc3);
        pci_release_regions(pdev);
        kfree(dev);