netdev
[Top] [All Lists]

Re: [PATCH 2.5.70] Add release_netdev -- hook for sysfs/net device clean

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH 2.5.70] Add release_netdev -- hook for sysfs/net device cleanup
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Sat, 7 Jun 2003 08:25:15 -0700
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20030607.020528.68152135.davem@redhat.com>
Organization: OSDL
References: <20030606145835.3a263df8.shemminger@osdl.org> <20030607.020528.68152135.davem@redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 07 Jun 2003 02:05:28 -0700 (PDT)
"David S. Miller" <davem@xxxxxxxxxx> wrote:

>    From: Stephen Hemminger <shemminger@xxxxxxxx>
>    Date: Fri, 6 Jun 2003 14:58:35 -0700
>    
>    Phase I:  introduces release_netdev which is the hook to allow later
>       changes to hold onto the net device after the device has potentially
>       unloaded.  Includes patch for the easy to fix devices. 
> 
> Besides naming (thought this was going to be named netdev_drop)
> I have no problems.
> 
> Al?

My (admittedly weak) rational for this was:
        - it seemed more like part of the register/unregister process
          and those functions are named {un}register_netdevice
        - RTNL should not be held, same as unregister_netdev
          (vs unregister_netdevice which requires it).
        - release rather than drop because release is used as name
          in the kobject callback hook

But it's easy to change now.

<Prev in Thread] Current Thread [Next in Thread>