Re: is sk->reuse truly a boolean?

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <20030520162906.GF801@xxxxxxxxxxxxxxxx> (at Tue, 20 May 2003 
13:29:07 -0300), Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx> says:

> > > In net/core/sock.c, setsockopt it just assigns 1 or 0, i.e. if userspace
> > > passes > 1 it becomes 1, is this the intended behaviour? I think we have 
> > > a 
> > > bug in tcp_ipv4 or in core/sock.c 8)
> > 
> > Good point. However, SO_REUSEADDR works because we have tcp_bind_conflict().
> 
> mmmkay, so we have to fix it by changing the test to:
> 
>                   if (sk->reuse)
>                          goto success;
> 
> Isn't it?

I don't think so.  Above modification will break current 
reasonable bind(2) behavior.

Well, it would be dead code, which would be used for (still 
unsupported) SO_REUSEPORT.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA