| To: | shemminger@xxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 2.5.69] Don't use destructor in bridge |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Fri, 09 May 2003 21:34:53 -0700 (PDT) |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20030509131515.6c3d34ca.shemminger@osdl.org> |
| References: | <20030509131515.6c3d34ca.shemminger@osdl.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: Stephen Hemminger <shemminger@xxxxxxxx> Date: Fri, 9 May 2003 13:15:15 -0700 This patch changes the Ethernet bridge back to the original way without having a destructor function. This is done so the route cache side effect code doesn't hold onto a reference to the device. If destructors are racy and do not work, we don't fix this by removing destructors from netdevice drivers. I do not accept this patch. We must fix the core problem. And your patch even creates a new problem. Remember how Alexey mentioned that that spinning/sleeping loop in unregister_netdevice() is deadlock prone and basically illegal itself. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2.5.69] Network packet type using RCU, Stephen Hemminger |
|---|---|
| Next by Date: | Re: [PATCH 2.5.69] Bridge timer performance enhancement, David S. Miller |
| Previous by Thread: | [PATCH 2.5.69] Don't use destructor in bridge, Stephen Hemminger |
| Next by Thread: | [PATCH 2.5.69] Bridge timer performance enhancement, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |