netdev
[Top] [All Lists]

Re: [PACTH][IPV6] Introduce ip6_append_data

To: kazunori@xxxxxxxxxxxx
Subject: Re: [PACTH][IPV6] Introduce ip6_append_data
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 16 Apr 2003 21:03:06 -0700 (PDT)
Cc: kuznet@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, usagi@xxxxxxxxxxxxxx
In-reply-to: <20030417130231.179c7f00.kazunori@miyazawa.org>
References: <20030417130231.179c7f00.kazunori@miyazawa.org>
Sender: netdev-bounce@xxxxxxxxxxx
You take direct page_address() of page, this is in general illegal.

Generally you must kmap the page to access it in the kernel as it may
be a HIGHMEM page.

I know that right now you control all the allocations with
alloc_page() and sk->allocation cannot currently allow highmem pages,
but let us not start with the assumptions right now :-)

As soon as you write udp6_sendfile() you will need to handle
this, that is for sure.

<Prev in Thread] Current Thread [Next in Thread>