netdev
[Top] [All Lists]

Re: [PATCH] [NET] use fl6_{src,dst} etc.

To: yoshfuji@xxxxxxxxxxxxxx
Subject: Re: [PATCH] [NET] use fl6_{src,dst} etc.
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 14 Apr 2003 10:31:43 -0700 (PDT)
Cc: kuznet@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, usagi@xxxxxxxxxxxxxx
In-reply-to: <20030415.023158.36869337.yoshfuji@linux-ipv6.org>
References: <20030415.023158.36869337.yoshfuji@linux-ipv6.org>
Sender: netdev-bounce@xxxxxxxxxxx
   From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
   Date: Tue, 15 Apr 2003 02:31:58 +0900 (JST)

I think this idea needs a slight modification:

   +#define fl_sport    uli_u.ports.sport
   +#define fl_dport    uli_u.ports.dport
   +#define fl_type             uli_u.icmpt.type
   +#define fl_code             uli_u.icmpt.code

Other protocols like DecNET will use these areas, and I already know
that DecNET defines it's own struct member of the flow uli_u union
that itself has members named sport and dport.

How about the following instead?

+#define fl_ports_sport uli_u.ports.sport
+#define fl_ports_dport uli_u.ports.dport
+#define fl_icmp_type           uli_u.icmpt.type
+#define fl_icmp_code           uli_u.icmpt.code

Ok?

<Prev in Thread] Current Thread [Next in Thread>