netdev
[Top] [All Lists]

Re: MOD_{INC,SEC}_USE_COUNT() in net/ipv{4,6}

To: davem@xxxxxxxxxx (David S. Miller)
Subject: Re: MOD_{INC,SEC}_USE_COUNT() in net/ipv{4,6}
From: kuznet@xxxxxxxxxxxxx
Date: Thu, 10 Apr 2003 06:54:38 +0400 (MSD)
Cc: yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, usagi@xxxxxxxxxxxxxx
In-reply-to: <20030409.180004.08009488.davem@redhat.com> from "David S. Miller" at Apr 9, 3 06:00:04 pm
Sender: netdev-bounce@xxxxxxxxxxx
Hello!

>    This patch (against 2.5.67) converts MOD_{INC,DEC}_USE_COUNT in 
>    net/ipv{4,6} to try_module_get() and module_put().
> 
> Applied, but

Why not to delete this things instead? Calls of these functions from
inside of module is completely meaningless.

I remember I put them there just to mimic behaviour of another devices,
but it was just a mistake.

Alexey

<Prev in Thread] Current Thread [Next in Thread>