Re: [PATCH] IPSec: Use of "sizeof" for header sizes, part II

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <20030401.193429.64279267.davem@xxxxxxxxxx> (at Tue, 01 Apr 2003 
19:34:29 -0800 (PST)), "David S. Miller" <davem@xxxxxxxxxx> says:

>    How about just removing 8 bytes from struct {ip,ipv6}_esp_hdr
>    like this?
>    
> Sure, but does anyone need the 8 bytes there?  I thought so, which is
> why I didn't think about your suggestion :-)

Let's define
  #define IPV6_ESP_MINDATA  8

and put "(sizeof(struct ip6_esp_hdr) + IPV6_ESP_MINDATA)" in such places.

Or, how about this?
  (offsetof(struct ip6_esp_hdr, enc_data) + datalen)
instead of
  ((sizeof(struct ip6_esp_hdr) - sizeof(esp->enc_data)) + datalen)

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA