| To: | toml@xxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH] IPSec: Use of "sizeof" for header sizes |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Mon, 31 Mar 2003 10:19:17 -0800 (PST) |
| Cc: | netdev@xxxxxxxxxxx, kuznet@xxxxxxxxxxxxx |
| In-reply-to: | <1049134030.1253.143.camel@tomlt2.tomloffice.austin.ibm.com> |
| References: | <1049134030.1253.143.camel@tomlt2.tomloffice.austin.ibm.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: Tom Lendacky <toml@xxxxxxxxxx>
Date: 31 Mar 2003 12:07:08 -0600
Below is a patch for your consideration eliminating the use of some
constants in the AH and ESP routines for IPv4 and IPv6. I believe
there was also a typo in a memcpy statement in net/ipv4/ah.c where
iph->ihl was multiplied by 5 instead of 4.
Thanks a lot Tom, Applied. Looks like not too many people have
been testing IPSEC links with IP options :-)
- use sizeof ip(v6)_esp_hdr and substract the sizeof enc_data
This sounds the best. It's a bit much to type, but it's the
most descriptive expression.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] IPSec: Use of "sizeof" for header sizes, Tom Lendacky |
|---|---|
| Next by Date: | Re: (usagi-users 02296) IPv6 duplicate address bugfix, Peter Bieringer |
| Previous by Thread: | [PATCH] IPSec: Use of "sizeof" for header sizes, Tom Lendacky |
| Indexes: | [Date] [Thread] [Top] [All Lists] |