Re: BUG or not? GFP_KERNEL with interrupts disabled.

["David S. Miller" <davem@xxxxxxxxxx>]

   From: "David S. Miller" <davem@xxxxxxxxxx>
   Date: Thu, 27 Mar 2003 12:55:07 -0800 (PST)

Alexey has pointed out a bug in my changes.

   @@ -1088,6 +1086,9 @@ void smp_percpu_timer_interrupt(struct p
                                     : /* no outputs */
                                     : "r" (pstate));
        } while (time_after_eq(tick, compare));
   +
   +    local_irq_enable();
   +    irq_exit();
    }
    
    static void __init smp_setup_percpu_timer(void)

Of course this is bogus.

The IRQ enable needs to occur in the irq_exit() branch right
before do_softirq() is invoked.