netdev
[Top] [All Lists]

Re: skb_padto and small fragmented transmits

To: christopher.leech@xxxxxxxxx
Subject: Re: skb_padto and small fragmented transmits
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 06 Feb 2003 10:44:24 -0800 (PST)
Cc: netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1044559370.4620.36.camel@localhost.localdomain>
References: <BD9B60A108C4D511AAA10002A50708F20BA2AAD1@orsmsx118.jf.intel.com> <1044559370.4620.36.camel@localhost.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Chris Leech <christopher.leech@xxxxxxxxx>
   Date: 06 Feb 2003 11:22:51 -0800
   
   I fail to see how the statement "skb->len + skb->data_len" has any
   usable meaning, or how it can be anything other than a bug.

This equation is the standard way to find the full length
on any skb.  For linear skbs, data_len is always zero.

I asked Alan to use this formula so that greps on the source
tree would always show data_len being taken into account, and
thus usage would be consistent.


<Prev in Thread] Current Thread [Next in Thread>