netdev
[Top] [All Lists]

Re: [PATCH] IPv6: Refine IPv6 Address Validation Timer

To: yoshfuji@xxxxxxxxxxxxxx (YOSHIFUJI Hideaki / 吉藤英明)
Subject: Re: [PATCH] IPv6: Refine IPv6 Address Validation Timer
From: kuznet@xxxxxxxxxxxxx
Date: Fri, 27 Sep 2002 19:30:14 +0400 (MSD)
Cc: davem@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, usagi@xxxxxxxxxxxxxx
In-reply-to: <20020928.001617.91124319.yoshfuji@linux-ipv6.org> from "YOSHIFUJI Hideaki / 吉藤英明" at Sep 28, 2 00:16:17 am
Sender: netdev-bounce@xxxxxxxxxxx
Hello!

> So, is this reasonable?

Yes, I like this.

Let's only delete this:

> +     if (time_before(now + HZ/2, jiffies)) {
> +             ADBG((KERN_WARNING 
> +                   "addrconf_verify(): too slow; jiffies - now = %ld\n",
> +                   (long)jiffies - (long)now));
> +     }

I do not understand how this survived. If you worry about infinite
spinning in loop you could make this check real, f.e. breaking loop
when jiffies >= now+2. In this form it is just mud.

Alexey


<Prev in Thread] Current Thread [Next in Thread>