| To: | yoshfuji@xxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH] IPv6: Improvement of Source Address Selection |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Fri, 27 Sep 2002 18:28:33 -0700 (PDT) |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, usagi@xxxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx |
| In-reply-to: | <20020928.001742.125874265.yoshfuji@linux-ipv6.org> |
| References: | <20020928.001742.125874265.yoshfuji@linux-ipv6.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Sat, 28 Sep 2002 00:17:42 +0900 (JST)
Please redesign this structure.
+struct addrselect_attrs {
+ struct inet6_ifaddr *ifp;
+ int match;
+ int deprecated;
+ int home;
+ int temporary;
+ int device;
+ int scope;
+ int label;
+ int matchlen;
+};
This is much larger than it needs to be. Please replace these "int"
binary states with single "u32 flags;" and appropriate bit
definitions.
This structure sits on the stack, so it is important to be
as small as we can easily make it.
Otherwise I have no problems with the patch, Alexey?
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] IPv6: Refine IPv6 Address Validation Timer, David S. Miller |
|---|---|
| Next by Date: | Re: [ANNOUNCE] NF-HIPAC: High Performance Packet Classification for Netfilter, David S. Miller |
| Previous by Thread: | Re: [PATCH] IPv6: Improvement of Source Address Selection, kuznet |
| Next by Thread: | Re: [PATCH] IPv6: Improvement of Source Address Selection, kuznet |
| Indexes: | [Date] [Thread] [Top] [All Lists] |