Re: [PATCH] IPv6: Refine IPv6 Address Validation Timer

["David S. Miller" <davem@xxxxxxxxxx>]

   From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
   Date: Fri, 27 Sep 2002 18:12:56 +0900 (JST)

This patch has problems.
    
   @@ -1626,24 +1635,32 @@
                for (ifp=inet6_addr_lst[i]; ifp; ifp=ifp->lst_next) {
                        unsigned long age;
    
   -                    if (ifp->flags & IFA_F_PERMANENT)
   +                    spin_lock(&ifp->lock);
   +                    if (ifp->flags & IFA_F_PERMANENT) {
   +                            spin_unlock(&ifp->lock);
                                continue;
   +                    }

This is completely unnecessary.  Nobody modifies the
IFA_F_PERMANENT flag after the addr entry has been added
to the hash table and this runs under the addrconf hash
lock already.

Alexey will have to comment on the rest.